[DO NOT MERGE] Reorder number 10 org page #3795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
changed the title
AshGDS
force-pushed
the
redesign-org-page
branch
from
51fcc25
to
15b14a5
Compare
AshGDS
force-pushed
the
redesign-org-page
branch
from
15b14a5
to
25f982c
Compare
AshGDS
force-pushed
the
redesign-org-page
branch
from
25f982c
to
29dd040
Compare
leenagupte
reviewed
Oct 16, 2024
Makes better use of the `first_featured_news` on the number 10 org page. The `remaining_featured_news` method then does what it says and returns all of the remaining news, rather than actually returning everything. `large: true` is being merged into the first item in `first_featured_news`, so that doesn't need to be repeated in the view. I'm not sure if these changes are having an affect on how the page is rendered.
[WIP] Redesign org page
KludgeKML
reviewed
Oct 17, 2024
| @@ -17,7 +17,14 @@ | |||
| } %> | |||
| </div> | |||
| </div> | |||
|
|
|||
| <% | |||
| @documents.first_featured_news[:context][:text] = "Featured" | |||
There was a problem hiding this comment.
You could theoretically get this from the localisation files, but don't let that be a blocker.
andysellick
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
contextfor the image card to say "Featured" as per the designs.first_featured_newsmeans the thumbnail is rendered at a higher resolution.Screenshots