Bump rack from 2.2.9 to 3.1.7 #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
|
|
There's a Trello card for this |
dependabot
bot
force-pushed
the
dependabot/bundler/rack-3.1.7
branch
2 times, most recently
from
b987b8e
to
2ce5301
Compare
Bumps [rack](https://github.com/rack/rack) from 2.2.9 to 3.1.7. - [Release notes](https://github.com/rack/rack/releases) - [Changelog](https://github.com/rack/rack/blob/main/CHANGELOG.md) - [Commits](rack/rack@v2.2.9...v3.1.7) --- updated-dependencies: - dependency-name: rack dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/rack-3.1.7
branch
from
2ce5301
to
538b0f9
Compare
brucebolt
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Could it be worth linking to the commit where this behaviour changed in rack?
This now returns an instance of `PrometheusExporter::Middleware` directly, instead of inside an array. From a quick scan, I couldn't find mention of this in the [Rack 3 upgrade guide][1], but the URL below takes you to the commit and lines in which this change was made rack/rack@b95cb72#diff-79892c6315a7f9c02489803e95ce828a8a32759b9f8f196aa98e6826eb562e55L69-R67 [1]: https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md
yndajas
force-pushed
the
dependabot/bundler/rack-3.1.7
branch
from
5616fb1
to
b0ca019
Compare
Nice find - couldn't spot it in the upgrade guide! I've added a link to those lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
Bumps rack from 2.2.9 to 3.1.7.
Release notes
Sourced from rack's releases.
Changelog
Sourced from rack's changelog.
... (truncated)
Commits
4bb2f72Bump patch version.1c1e413Ignore external tests directory.b4a1036Prepare for 3.1.7 release.d0da91bAdd more external tests.f6f1510ImproveRack::Responsecontent-length header generation. (#2219)fb339e0Fix encoding setting for non-binary IO-like objects in MockRequest#env_fore21872dDo not remove escaped opening/closing quotes for content-disposition filenames5c3d79fSynchronize changelog with HEAD.bca33b4Allow empty PATH_INFO. (#2214) (#2234)98aa947Bump patch version.Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)