Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed remote ports #643

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Fixed remote ports #643

merged 1 commit into from
Jan 22, 2025

Conversation

LanderOtto
Copy link
Collaborator

@LanderOtto LanderOtto commented Jan 20, 2025

This commit fixes the injection of remote inputs using the cwl_utils objects. Also, the unit test for input injection has been improved. Now, other than checking the path of the output token of the InputInjectorStep, the input file is copied to the same location, and a checksum check is performed.

This commit also updates the Docker MacOS GitHub Action to the latest version.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 71.37%. Comparing base (6e21f11) to head (12b1ffa).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
streamflow/cwl/translator.py 18.18% 4 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   71.37%   71.37%   -0.01%     
==========================================
  Files          88       88              
  Lines       11310    11310              
  Branches     1968     1968              
==========================================
- Hits         8073     8072       -1     
  Misses       2782     2782              
- Partials      455      456       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LanderOtto LanderOtto force-pushed the fix/inject branch 3 times, most recently from 6df1895 to 4b04979 Compare January 21, 2025 08:38
…objects.

The unit test for injector input has been improved. Now, in addition to checking the path of the output token of the `InputInjectorStep`, the file is copied to the same location, and a checksum check is performed.

Moreover, this commit updates the docker macos action version
@GlassOfWhiskey GlassOfWhiskey merged commit 665a0c5 into master Jan 22, 2025
32 checks passed
@GlassOfWhiskey GlassOfWhiskey deleted the fix/inject branch January 22, 2025 06:07
@LanderOtto LanderOtto mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants