-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some CWL translator issues #628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
LanderOtto
force-pushed
the
fix/elem-out
branch
2 times, most recently
from
December 18, 2024 11:17
1599d32
to
44e2c9a
Compare
LanderOtto
changed the title
Fixed the retrieval of the step name in the CWL translator
Fixed some CWL translator issues
Dec 18, 2024
LanderOtto
force-pushed
the
fix/elem-out
branch
2 times, most recently
from
December 18, 2024 16:01
dccecb7
to
3cb7ec9
Compare
LanderOtto
force-pushed
the
fix/elem-out
branch
2 times, most recently
from
December 28, 2024 21:49
59eea37
to
d956f9b
Compare
LanderOtto
force-pushed
the
fix/elem-out
branch
7 times, most recently
from
January 4, 2025 13:45
7840d0b
to
6267b03
Compare
LanderOtto
force-pushed
the
fix/elem-out
branch
7 times, most recently
from
January 9, 2025 18:55
5a03e0e
to
6bc009b
Compare
LanderOtto
force-pushed
the
fix/elem-out
branch
from
January 18, 2025 09:14
6bc009b
to
e40222a
Compare
- the retrieval of the step name. Before this commit, it was expected that the `out` attribute of `WorkflowStep` was always a list of `string`. Instead, it is a list of `Any`, following the typing hint of the `cwl_utils.parser.WorkflowStep` constructor. In particular, it can have `WorkflowStepOutput` object elements. - the creation of the `CommandOutputProcessor` when a schema is defined. Before this commit, the `CommandInputRecordSchema` was not included in the `RecordSchema` case. Similar for `EnumSchema` and `ArraySchema` cases, respectively.
…flow, the `element_id` is: `/path/to/file#id`
… this commit, it was saved the path defined in the `StreamFlow file`, which can be a relative path
LanderOtto
force-pushed
the
fix/elem-out
branch
from
January 19, 2025 11:27
e40222a
to
ea425c9
Compare
GlassOfWhiskey
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes several CWL translator issues:
cwl-utils
objects. Before this commit, theout
attribute of aWorkflowStep
object was always expected to be a list of strings. Instead, it should be a list ofAny
, following the typing hint of thecwl_utils.parser.WorkflowStep
constructor. In particular, it can containWorkflowStepOutput
objects.CommandOutputProcessor
creation when a schema is defined. Before this commit, theCommandInputRecordSchema
was not included in theRecordSchema
case. Similar forEnumSchema
andArraySchema
cases, respectively.optional
inputs inside a scatter step_get_path
method in the CWL translator module. When theid
field is explicitly defined in a CWL file, theelement_id
of the corresponding Python object is constructed as/path/to/file#id
DataManager
. Before this commit, it was saved the path defined in the StreamFlow file, which could be a relative pathoptional
inputs of typelist
orrecord
. Before this commit, some workflows were failing because their input data were erroneously treated as mandatory