Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate uvloop async engine #531

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

GlassOfWhiskey
Copy link
Member

@GlassOfWhiskey GlassOfWhiskey commented Aug 24, 2024

This commit integrates the uvloop asynchronous engine as a drop-in replacement for asyncio when Python runs on top of the Cython library. The uvloop library is faster than the standard async engine, improving StreamFlow performance epsecially on HTC workflows.

This PR cannot be integrated due to the MagicStack/uvloop#457 issue, which prevents StreamFlow from correctly interacting with snap-based libraries on Ubuntu systems.

This commit integrates the `uvloop` asynchronous engine as a drop-in
replacement for `asyncio` when Python runs on top of the `Cython`
library. The `uvloop` library is faster than the standard async engine,
improving StreamFlow performance epsecially on HTC workflows.
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.07%. Comparing base (723bac0) to head (af22c0c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
streamflow/main.py 16.66% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   70.10%   70.07%   -0.03%     
==========================================
  Files          87       87              
  Lines       10913    10919       +6     
  Branches     2265     2266       +1     
==========================================
+ Hits         7651     7652       +1     
- Misses       2824     2830       +6     
+ Partials      438      437       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlassOfWhiskey GlassOfWhiskey force-pushed the master branch 2 times, most recently from 9660fdc to 90a078e Compare December 13, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant