-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-936: Support Address
es and OP_RETURN
s as withdrawal destinations
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit: 12d5b59 SP1 Performance Test Results
|
storopoli
force-pushed
the
STR-754
branch
2 times, most recently
from
January 13, 2025 16:15
a9e7fce
to
5471b8f
Compare
storopoli
force-pushed
the
STR-754
branch
9 times, most recently
from
January 15, 2025 20:13
111d0ee
to
03309d9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
13 tasks
storopoli
force-pushed
the
STR-754
branch
5 times, most recently
from
January 17, 2025 15:24
07e9af6
to
2590cd7
Compare
storopoli
commented
Jan 17, 2025
delbonis
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now the bridge supports withdraws only to P2TR. The user passes an X-only PK to the bridge withdrawal precompile address.
However we need to support any arbitrary address, along with
OP_RETURN
s as valid withdrawal destinations.Type of Change
Notes to Reviewers
We are not thoroughly testing that the
OP_RETURN
payload is actually being published on-chain (bitcoin). See https://alpenlabs.atlassian.net/browse/STR-919 for context. But the withdraw would fail otherwise, so it's tested-ish.Checklist
Related Issues
STR-936