Transform Iterator #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bernhard Manfred Gruber <[email protected]>
…' into constant-iterator
fixed constant iterator integration test
SimeonEhrig
reviewed
Jan 26, 2022
| using iterator_category = std::random_access_iterator_tag; | ||
|
|
||
| using TInputIteratorDeref = decltype(*std::declval<TInputIterator>()); | ||
| using AccObjPtr = AccObj*; |
There was a problem hiding this comment.
I recognized, there is a big problem. At the moment, I don't know a way to determine the Acc type one the host side, before the algorithm is running. The concrete Acc type is injected by alpaka. Therefore, the type is first available, if the functor is called. I need to discuss the problem with the alpaka maintainer. Therefore, I recommend to implement the transform iterator without support for the acc object at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests being done with the accelerator yet
Should also add tests with functor objects that implement operator() and lambdas