Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add get_corporate_actions #502

Merged
merged 6 commits into from
Nov 8, 2024
Merged

feat: Add get_corporate_actions #502

merged 6 commits into from
Nov 8, 2024

Conversation

hiohiohio
Copy link
Contributor

@hiohiohio hiohiohio commented Aug 26, 2024 •
edited
Loading

Fixes #481

Context:

Changes:

  • add get_corporate_actions

@gnvk
Copy link
Contributor

gnvk commented Aug 27, 2024

Please also add an example to stocks-trading-basic.ipynb with some explanation (e.g getting the splits fro the last week or something).

hiohiohio
hiohiohio commented Nov 7, 2024
View reviewed changes
Copy link
Contributor Author

@hiohiohio hiohiohio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! As I am originator of this PR, I cannot approve this. So, let's wait another eye.

alpaca/data/models/base.py Outdated Show resolved Hide resolved
alanvoss
alanvoss approved these changes Nov 7, 2024
View reviewed changes
Copy link

@alanvoss alanvoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gnvk gnvk merged commit 370b86b into master Nov 8, 2024
12 checks passed
@gnvk gnvk deleted the feat-add-corporate-actions-data branch November 8, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnvk gnvk gnvk left review comments

@alanvoss alanvoss alanvoss approved these changes

@sai-g sai-g Awaiting requested review from sai-g

@AlexandrosKyriakakis AlexandrosKyriakakis Awaiting requested review from AlexandrosKyriakakis

@matebudai matebudai Awaiting requested review from matebudai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the new corporate actions endpoint to the SDK
3 participants
@hiohiohio @gnvk @alanvoss