Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate aloe command #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tysonclugg
Copy link
Contributor

A continuation of #114 but deprecating the aloe command altogether.

@tysonclugg
Copy link
Contributor Author

So... I wanted you to see the result of the second commit (ie: 1 failed test) so I could then ask the question: Do you plan on using aloe to test aloe?

The failing test is because we're using coverage run -m nose in .travis.yml which now runs all tests by default (ie: my changes work). However... I couldn't get coverage run -m aloe/__main__.py running properly. Either I'm doing something wrong, or it's broken and the aloe command should be removed entirely...

@koterpillar
Copy link
Member

Aloe command will not be deprecated just yet - it might be useful on its own.

A big issue here is #108. Nose is dead (on life support), django_nose will have a hard time with Django 1.10 because of argparse. If you are using Nose, I'll be keen to hear your thoughts there.

I support the idea here though: whatever test framework Aloe ends up with, running it with Aloe as a plugin should run Gherkin tests in addition to ones that would normally run.

@tysonclugg
Copy link
Contributor Author

Nose still works, I wouldn't remove support for it unless there's a good reason to do so (such as if supporting nose becomes difficult).

I'd rather add support for py.test while keeping the existing nose plugin if that is an option. If still you're keen on dropping support for nose, then consider issuing a DeprecationWarning from the nose plugin and give developers some time to transition to py.test, or even something else.

Regarding "something else", one option would be to write a wrapper around unittest.TestCase and/or unittest.TestSuite (perhaps using metaclasses) such that normal unittest discovery by nose2/py.test/other would work. Make sure that generated classes can have defined class inheritance (eg: via django.test.TestCase) and then usefull stuff Django setup/teardown behaviour can be used without hassle...

@koterpillar
Copy link
Member

See #108 for discussions of test frameworks (summary: I want it to be usable with either).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants