Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run NCalcEMA if already at same value #737

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Do not run NCalcEMA if already at same value #737

wants to merge 2 commits into from

Conversation

xmariachi
Copy link
Contributor

@xmariachi xmariachi commented Jan 20, 2025 •
edited
Loading

Purpose of Changes and their Description

Efficiency: do not run NCalcEMA if already at same value

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- unit tests
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, just optim
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title Optimize: do not run NCalcEMA if already at same value Do not run NCalcEMA if already at same value Jan 20, 2025
@xmariachi xmariachi marked this pull request as ready for review January 20, 2025 17:52
amimart
amimart approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amimart amimart amimart approved these changes

@kpeluso kpeluso Awaiting requested review from kpeluso

@guilherme-brandao guilherme-brandao Awaiting requested review from guilherme-brandao

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xmariachi @amimart