Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix topic low-weight inactive topic weight vulnerability #736

Conversation

xmariachi
Copy link
Contributor

Purpose of Changes and their Description

  • Fix vulnerability: if topic has not been (re)activated, then the topic weights should not change.
  • Change isAdded, error for just error on addTopicToActiveSetRespectingLimitsWithoutMinWeightReset, adding some error types. The flag was not really adding value, while not processing the flag would lead to a vulnerability like the one found.

Link(s) to Ticket(s) or Issue(s) resolved by this PR

Are these changes tested and documented?

  • If tested, please describe how. If not, why tests are not needed. -- existing unit tests
  • If documented, please describe where. If not, describe why docs are not needed. -- no need, changes in functions not user-facing.
  • Added to Unreleased section of CHANGELOG.md?

@xmariachi xmariachi changed the title Remove isAdded flag, handle error types Fix topic low-weight inactive topic weight vulnerability Jan 20, 2025
@xmariachi xmariachi marked this pull request as ready for review January 20, 2025 17:53
@xmariachi xmariachi closed this Jan 23, 2025
@xmariachi xmariachi deleted the diego/proto-3256-totalsumprevioustopicweights-can-be-set-to-any-value branch January 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant