fix the issue when adding rows in Initial Graph Setup tab #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenzhuaz
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Great catch, thank you @XDeng0921. LGTM, now I see the values to assign each component as an reactive value, when use it for "update", as @nanxstats always suggests 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the additional row was added into MatrixInput in the initial graph tab, gMCP function in iterative tab will throw error. To fix the issue, the rows in the MatrixInput with empty entry string were deleted before putting in gMCP calculation.