Add tagger_modules option to tagger cli #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the user to provide a list of modules to load custom taggers from.
Enable the user to provide a list of modules to load custom taggers from.
…lma into extendable_tagger_cli
The TaggerRegistry gets reimporterd on the child processes when they are spawned, so we need to import the tagger modules in the child processes or the taggers will not be present in the registry.
soldni
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Looks good @peterbjorgensen ! I've taken the liberty to modify the import function to support paths, added tests, and included documentation.
|
Thanks a lot for merging this PR @soldni and the awesome improvements you've made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the user to provide a list of modules to load custom taggers from.
The Dolma CLI is fully configurable through config files except when it comes to adding custom taggers.
This PR adds the option to load Python modules that could add to the
TaggerRegistry