Spring boot 3.1.2 #398
Merged
Spring boot 3.1.2 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferdudas97
reviewed
Sep 4, 2023
...src/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/NodeMetadataValidatorTest.kt
Show resolved
Hide resolved
kozjan
force-pushed
the
spring-boot-3.1.2
branch
from
9f765b1
to
eb572b4
Compare
KSmigielski
reviewed
Sep 5, 2023
...trol-tests/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/reliability/Toxiproxy.kt
Show resolved
Hide resolved
...sts/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/EndpointMetadataMergingTests.kt
Outdated
Show resolved
Hide resolved
...runner/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/chaos/api/ChaosController.kt
Outdated
Show resolved
Hide resolved
kozjan
force-pushed
the
spring-boot-3.1.2
branch
from
4d976e3
to
620b841
Compare
kozjan
force-pushed
the
spring-boot-3.1.2
branch
from
620b841
to
213d4ee
Compare
kozjan
force-pushed
the
spring-boot-3.1.2
branch
from
213d4ee
to
0d542b8
Compare
KSmigielski
approved these changes
Sep 8, 2023
Ferdudas97
approved these changes
Sep 11, 2023
| import java.net.ServerSocket | ||
| import pl.allegro.tech.servicemesh.envoycontrol.logger | ||
|
|
||
| object Ports { |
There was a problem hiding this comment.
Maybe it can be moved to test, because it is only used there
There was a problem hiding this comment.
moving Ports to test causes errors in envoy-control-tests, since it has evony-control-core as a dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.