[add] more log for send fail

[fix] crash if call empty GetReservedAttempts
aliyun · Sep 24, 2019 · d3a95d1 · d3a95d1
1 parent 7f2b85e
commit d3a95d1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/producer/io_worker.go b/producer/io_worker.go
@@ -1,13 +1,14 @@
 package producer
 
 import (
-	"github.com/aliyun/aliyun-log-go-sdk"
-	"github.com/go-kit/kit/log"
-	"github.com/go-kit/kit/log/level"
 	"math"
 	"sync"
 	"sync/atomic"
 	"time"
+
+	sls "github.com/aliyun/aliyun-log-go-sdk"
+	"github.com/go-kit/kit/log"
+	"github.com/go-kit/kit/log/level"
 )
 
 type CallBack interface {
@@ -70,6 +71,7 @@ func (ioWorker *IoWorker) sendToServer(producerBatch *ProducerBatch, ioWorkerWai
 			}
 			return
 		}
+		level.Info(ioWorker.logger).Log("msg", "sendToServer failed", "error", err)
 		if slsError, ok := err.(*sls.Error); ok {
 			if _, ok := ioWorker.noRetryStatusCodeMap[int(slsError.HTTPCode)]; ok {
 				ioWorker.excuteFailedCallback(producerBatch)

diff --git a/producer/result.go b/producer/result.go
@@ -40,16 +40,25 @@ func (result *Result) GetErrorCode() string {
 }
 
 func (result *Result) GetErrorMessage() string {
+	if len(result.attemptList) == 0 {
+		return ""
+	}
 	cursor := len(result.attemptList) - 1
 	return result.attemptList[cursor].ErrorMessage
 }
 
 func (result *Result) GetRequestId() string {
+	if len(result.attemptList) == 0 {
+		return ""
+	}
 	cursor := len(result.attemptList) - 1
 	return result.attemptList[cursor].RequestId
 }
 
 func (result *Result) GetTimeStampMs() int64 {
+	if len(result.attemptList) == 0 {
+		return 0
+	}
 	cursor := len(result.attemptList) - 1
 	return result.attemptList[cursor].TimeStampMs
 }