Behaviour Prefixes (for CDK v2 upgrade) #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnholland
changed the title
TheOrangePuff
requested changes
Oct 15, 2024
TheOrangePuff
requested changes
Oct 16, 2024
| additionalBehaviors[`${prefix.prefix}*`] = { | ||
| origin: s3Origin, | ||
| viewerProtocolPolicy: ViewerProtocolPolicy.REDIRECT_TO_HTTPS, | ||
| edgeLambdas: prefix.edgeLambdas, | ||
| edgeLambdas: prefix.behaviourOverride.edgeLambdas, |
There was a problem hiding this comment.
Instead of just passing the edge lambda you can do this:
additionalBehaviors[`${prefix.prefix}*`] = {
origin: s3Origin,
viewerProtocolPolicy: ViewerProtocolPolicy.REDIRECT_TO_HTTPS,
originRequestPolicy: originRequestPolicy,
cachePolicy: originCachePolicy,
responseHeadersPolicy: responseHeadersPolicy,
...prefix.behaviourOverride,
};Because that will then allow you to override any of the properties if you need
There was a problem hiding this comment.
@finn-holland-aligent this one hasn't been resolved yet
| @@ -140,11 +140,14 @@ export interface StaticHostingProps { | |||
| enableStaticFileRemap?: boolean; | |||
|
|
|||
| /** | |||
| * Any prefixes to remapping that should be included in the path such as au or nz | |||
| * Overrides default behaviour paths with a prefix and takes in options to apply to each static file behaviour | |||
There was a problem hiding this comment.
The options don't apply to the static file behaviour do they?
finnholland
force-pushed
the
behaviour_prefixes
branch
from
6049cea
to
faa19f8
Compare
finnholland
force-pushed
the
behaviour_prefixes
branch
from
1445070
to
4dc214d
Compare
TheOrangePuff
requested changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
idtag to prerender function names to avoid duplicate named function issuesbehaviourPrefixesto allow for behaviours on regional prefixes such asau/ornz/Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback