Feature/do 1357 cdk v2 templating #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 22, 2024 11:31
…ch version update to match release numbers
- clarify which headers are needed for each - make the header list customisable
crispy101
changed the title
TheOrangePuff
requested changes
Sep 2, 2024
| @@ -33,7 +33,7 @@ export class PathRemapFunction extends Construct { | |||
| local: new Esbuild({ | |||
| entryPoints: [join(__dirname, "handlers/remap.ts")], | |||
| define: { | |||
| "process.env.REMAP_PATH": options.path, | |||
| "process.env.REMAP_PATH": '"' + options.path + '"', | |||
There was a problem hiding this comment.
Can this be changed to:
"process.env.REMAP_PATH": `"${options.path}"`,
I think it's just a little cleaner
| "x-forwarded-host", // Origin response may vary depending on the domain/path based on Feature Environment | ||
| "x-prerender", // Origin response may vary depending on whether the request is from end user or prerender service. | ||
| ]; | ||
| if (props.additionalDefaultCacheKeyHeaders) { |
There was a problem hiding this comment.
Same comment about the spread operator here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Screenshots (if applicable)
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback