Mesh Updates #1109
Merged
Mesh Updates #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nal redis database config and env var so we can share redis clusters between mesh instances.
Create a cross account supported way of sending slack notifications whenever GraphQl mesh is deployed
|
Looks like I missed the slack notifications with the last PR, it was sitting on another branch. I've merged that here as well to bring it all inline. |
gowrizrh
reviewed
Oct 13, 2023
gowrizrh
previously approved these changes
Oct 13, 2023
TheOrangePuff
previously approved these changes
Oct 16, 2023
AdamJHall
dismissed stale reviews from TheOrangePuff and gowrizrh
via
f1584dd
|
@gowrizrh and @TheOrangePuff can you please re-review? There were some merge conflicts that needed to be fixed up. |
gowrizrh
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
This PR updates the mesh construct to use the VPC interface so that we can import existing vpcs if required. I have also added the database config value for redis so that the mesh can use a shared redis instance with different databases for each.
Notes to PR author
Notes to reviewers
🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback