Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MICRO-150: Graphql mesh server #1065

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

TheOrangePuff
Copy link
Contributor

Description of the proposed changes

  • Adds graphql-mesh-hosting construct

Notes to PR author

⚠️ Please make sure the changes adhere to the guidelines mentioned here

Notes to reviewers

🛈 When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@krishanthisera
Copy link
Contributor

krishanthisera commented Aug 30, 2023

@TheOrangePuff I think you would need to pull the latest changes from the main branch, which would fix the build issue.

Cheers 🥂

Copy link
Contributor

@krishanthisera krishanthisera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to pull the latest changes from the main branch, which would fix the build issue.

@AdamJHall
Copy link
Contributor

I think we would need to pull the latest changes from the main branch, which would fix the build issue.

Pulling in main created a whole bunch of merge conflicts, but I was able to just update the calls to the Bundling utility which fixed the issue instead.

Copy link
Contributor

@krishanthisera krishanthisera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 🥂

@AdamJHall AdamJHall merged commit 42114ea into feature/DO-1285-upgrade-cdk Aug 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants