Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vdn@github - har-convertor-jmeter-tool #48

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Add vdn@github - har-convertor-jmeter-tool #48

merged 2 commits into from
Mar 20, 2024

Conversation

vdaburon
Copy link
Contributor

Add vdn@github - har-convertor-jmeter-tool in Conversion tools

Add vdn@github - har-convertor-jmeter-tool in Conversion tools
@vdaburon
Copy link
Contributor Author

Hi,
I see a error the name github but this is the name of my JMeter plugin : "vdn@github - har-convertor-jmeter-tool"
Could you remove this rule about github name format or change the plugin name to : "vdn@GitHub - har-convertor-jmeter-plugin" ?

@aliesbelik
Copy link
Owner

@vdaburon, appreciate your contribution but it looks at least a bit strange as for me to ask to change the rules in someone else's project just because you want to promote your own.

This project tries to fit awesome community guidelines, and awesome-linter check is part of it.

@vdaburon
Copy link
Contributor Author

vdaburon commented Mar 18, 2024

Thanks aliesbelik.
Some explanations :
You could find 2 plugins to convert a har file to jmeter script

  1. HAR (HTTP Archive) Import
  2. vdn@github - har-convertor-jmeter-tool

I prefixe the name of my plugins with "vdn@github" (for vincent daburon at github) but there is a rule to check the github name and i don't know this rule.
I use the same synthax as plugins prefixe with "jp@gc" for jmeter plugins at google code.

image

My question : Why write github and not GitHub is a blocking error ?

Regards.
Vincent DABURON

@aliesbelik
Copy link
Owner

  1. I'm not sure I understand how the appearance of plugin in jmeter-plugins catalog and this PR are connected.
    As you could ensure there are not prefixed names in this list.

  2. My question : Why write github and not GitHub is a blocking error ?

I guess this relates rather to the awesome-lint implementation and rules.
I'm not planning to disable linter for PRs check.

  1. I've added small change to your PR to pass the check, if it's acceptable for you.
    Naming in accordance to the github project name (har-convertor-jmeter-tool/har-convertor-jmeter-plugin) seems fine for me and doesn't generate errors.

@vdaburon
Copy link
Contributor Author

OK for the name "har-convertor-jmeter-tool" for the JMeter plugin.
Next time I will be careful with the GitHub name.
Thanks.

@aliesbelik aliesbelik merged commit 9a106b4 into aliesbelik:main Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants