Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add installation for higress standalone in local docker environment #606

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

2456868764
Copy link
Collaborator

@2456868764 2456868764 commented Oct 27, 2023

Ⅰ. Describe what this PR did

  1. support to install higress in local docker environment
  2. add -f param to customize helm vlaues for installation and upgrade.
  3. enable gatewayapi and reduce profile structure

Ⅱ. Does this pull request fix one issue?

fixes #572 #570 #608

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #606 (390c4c4) into main (de1dd3b) will decrease coverage by 0.57%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   35.87%   35.30%   -0.57%     
==========================================
  Files          70       71       +1     
  Lines       10114    10240     +126     
==========================================
- Hits         3628     3615      -13     
- Misses       6201     6339     +138     
- Partials      285      286       +1     
Files Coverage Δ
pkg/cmd/hgctl/dashboard.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/manifest.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/util/util.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/install.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/uninstall.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/upgrade.go 0.00% <0.00%> (ø)
pkg/cmd/hgctl/util/http_fetcher.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@2456868764 2456868764 changed the title add installation for higress standalone in local docker environment feat:add installation for higress standalone in local docker environment Oct 27, 2023
@johnlanni johnlanni requested a review from CH3CHO October 31, 2023 08:50
@johnlanni
Copy link
Collaborator

I think hgctl gateway-config/dashboard also need support local docker enviroment. Are you interested in implementing it, or creating an issue to track it?

@johnlanni
Copy link
Collaborator

cc @CH3CHO @Xunzhuo

@2456868764
Copy link
Collaborator Author

I think hgctl gateway-config/dashboard also need support local docker enviroment. Are you interested in implementing it, or creating an issue to track it?

i will create an issue to track and implement it later.

@2456868764 2456868764 force-pushed the hgctl-docker-installation branch from e5f2664 to 1e5dab2 Compare November 2, 2023 00:04
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnlanni johnlanni merged commit 9136908 into alibaba:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hgctl 支持本地Docker 环境安装
4 participants