add bank factory interface duo to make creation of bank factory cleaner and shorter #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ممنون از مشارکت ارزشمند شما @mojtabaakbari221b |
birddevelper
suggested changes
Oct 4, 2024
| callback_url=callback_url, | ||
| mobile_number=mobile_number, | ||
| ) | ||
| return bank.redirect_gateway() |
There was a problem hiding this comment.
لطفا در مثالتون قبل از فراخوانی redirect_gateway متد ready رو هم اضافه کنید تا اگر کسی از مثال شما استفاده کرد به مشکل بر نخوره.
# ...
bank_record = bank.ready()
return bank.redirect_gateway()
# ...
|
تغییراتی که گفتید رو اعمال کردم. ممنونم از شما |
birddevelper
approved these changes
Oct 16, 2024
|
تشکر آقای اکبری عزیز. @mojtabaakbari221b |
|
🎉 This PR is included in version 2.0.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
برای ساختن یک instance از روی bank factory، نیاز به نوشتن کد زیاد و تکراری بود. همه‌ی این کارهارو بردم توی یه interface تا کار ساختن یه instance ساده تر انجام بشه.
دلیل اینکه توی یه فایل جدا نوشتم هم این بود چون خیلیا با ورژن قبلی راحت‌ترن، بعد آپدیت نیاز نباشه مجدد کدشون رو دست بزنند