Add extmap-allow-mixed SDP attribute
#551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
reviewed
Aug 2, 2024
|
Only if you are going to optionally enable/disable RTP extensions that need this feature based on this (e.g. jitsi), which is not the case at the moment. Janus just adds this line regardless of anything. |
|
Alright. Can you make a code comment to that effect, linking to the janus impl? Then we merge. |
lolgesten
approved these changes
Aug 2, 2024
algesten
approved these changes
Aug 2, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I`ve been experimenting with AV1 SVC, and it seems that Chrome won't send Dependency Descriptor RTP Header Extension if a=extmap-allow-mixed is not signaled by the remote, so here it is.