Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support getting stream_id and track_id of Media #550

Merged
merged 2 commits into from
Aug 3, 2024

Conversation

uwuPyxl
Copy link
Contributor

@uwuPyxl uwuPyxl commented Jul 27, 2024

Get the stream_id and track_id from the incoming MediaLine and expose them to users on the resulting Media so they can tell incoming Media apart. Should the incoming Media not have a Msid attribute this falls back to the previous behavior of generating random ids

@algesten
Copy link
Owner

Hey! Thanks for this!

I was under the impression that msid was deprecated, but I think I'm mistaken. The a=ssrc lines are not in fashion anymore, which means getting msid there is not a good idea. But this PR is working with a=msid, which seems to still be good API. Is that your understanding too?

@uwuPyxl
Copy link
Contributor Author

uwuPyxl commented Jul 28, 2024

I just used the msid attribute since it was most obvious and convenient but yeah it does seem to be intended for this purpose.

Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Let's merge, but 3 small formatting things first.

src/media/mod.rs Show resolved Hide resolved
src/sdp/data.rs Show resolved Hide resolved
src/sdp/data.rs Show resolved Hide resolved
@uwuPyxl
Copy link
Contributor Author

uwuPyxl commented Aug 2, 2024

I've updated the formatting manually, but it should be possible to set up a rustfmt.toml to configure the formatting rules

@algesten algesten merged commit ae5bcd7 into algesten:main Aug 3, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants