-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #67 | provide a way to clear the queries array #74
base: master
Are you sure you want to change the base?
Conversation
Hi @gprasant! I'm helping @JangoSteve with Dynatable. We're getting ready to move forward with a lot of overdue work. We're having a meeting about all open PRs next week. We do require that all contributors sign the CLA. Are you available to do so? |
whats the CLA ? |
Our license requires that people contributing release rights to the copyright holder. Here is the link: https://www.clahub.com/agreements/alfajango/jquery-dynatable - Please let me know if you have any more questions! |
done — On Mon, Oct 26, 2015 at 11:15 AM, Max Langensiepen
|
This looks good. While we're at it, I may make it more parallel to the I'd just remove the comment line at least though. |
@@ -1137,6 +1137,12 @@ | |||
return dt; | |||
}; | |||
|
|||
this.clear = function() { | |||
settings.dataset.queries = {}; | |||
// not sure what the event arg should be if I trigger teh :removed event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably can get rid of this comment line.
Tested with the following cases: