Add impl for Clone trait for FontVec #111
Conversation
It justs called 2 exist method.
|
Cloning font data is quite inefficient though as fonts are often fairly large, if you need to clone it is much better to use a Can you help me understand the use case? |
| @@ -104,6 +104,12 @@ impl fmt::Debug for FontVec { | |||
| } | |||
| } | |||
|
|
|||
| impl Clone for FontVec { | |||
| fn clone(&self) -> Self { | |||
| Self::try_from_vec(self.as_slice().to_vec()).unwrap() | |||
There was a problem hiding this comment.
I think this impl means that mutations, e.g. setting variations, will not be present in the "cloned" output which would be incorrect.
There was a problem hiding this comment.
Well, I have no better ideas. Maybe byte-to-byte clone?
Well, you're probably right.
Well, someone may using an old computer that have no Arc support. Note: This type is only available on platforms that support atomic loads and stores of pointers, which includes all platforms that support the std crate but not all those which only support alloc. This may be detected at compile time using #[cfg(target_has_atomic = "ptr")]. -- The Rust Standard Library Document, std::sync::Arc |
This implements
Clonetrait forFontVec.It is just a small change,
but it can co-operate with a lot of Rust's generic mechanism (e.g.
impl<T, A> Clone for Vec<T, A>),and are good for convienience (e.g. now we can
vec_of_fontvecs.clone()).