Fix int parsing for arg:"env" when environment variable value is empty #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexflint
requested changes
Oct 24, 2021
| values, err = csv.NewReader(strings.NewReader(value)).Read() | ||
| value = strings.TrimSpace(value) | ||
|
|
||
| if len(value) > 0 { |
There was a problem hiding this comment.
I think this will break the case that an argument type is *string and the env var is present but is empty, in which case the argument should be initialized to a non-null string, but its contents should be empty.
There was a problem hiding this comment.
Yeah, I missed this situation right now the argument is initialized null when this happens. I will work on this fix
| @@ -677,6 +677,42 @@ func TestEnvironmentVariable(t *testing.T) { | |||
| assert.Equal(t, "bar", args.Foo) | |||
| } | |||
|
|
|||
| func TestEnvironmentVariableInt(t *testing.T) { | |||
There was a problem hiding this comment.
Would you add 3 extra test cases:
- argument type is
*stringand environment variable is absent - argument type is
*stringand environment variable is present and empty - argument type is
*stringand environment variable is present and non-empty
when, argument type is *string and environment variable is absent argument type is *string and environment variable is present and empty argument type is *string and environment variable is present and non-empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in reference to #160