Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scraps the original API and intention to resolve segments locally. That is something to investigate but for a pragmatic start I'm mirroring the Flipt API and will tinker with some other SDKs and find the common effectful vs pure parts.
Flipt seems to make a HTTP request for everything, including getting flags. It is possible to list multiple flags but it's unclear if the API automatically paginates, meaning we could miss flags trying to get them all up front. It also evaluates segments server side, however the ideal goal here is fetch the whole flag state once in request middleware, cache it, and have enough info to resolve segment allocation locally.
Will eventually tinker with a pure Scala Flipt reimplementation, and see how much can be done app-side instead of server side.