Skip to content

Commit

Permalink
Turn on blocking build for AVX512 and SVE on GHA (facebookresearch#3717)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookresearch#3717

they have been running in shadow mode for quite some time now.
 I spot-checked the builds for the past 10 jobs and they all look good. Since `continue-on-error` will always mark a job as "green" even if it fails, I need a way to holistically verify these builds actually work reliably. Turning the builds to blocking to accomplish that.

Reviewed By: ramilbakhshyiev

Differential Revision: D60692521

fbshipit-source-id: 172a6362c672b0376c76559f12852110936756df
  • Loading branch information
mengdilin authored and facebook-github-bot committed Aug 2, 2024
1 parent a757309 commit 0b2328f
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,17 +56,14 @@ jobs:
opt_level: avx2
linux-x86_64-AVX512-cmake:
name: Linux x86_64 AVX512 (cmake)
continue-on-error: true # non-blocking mode for now
needs: linux-x86_64-cmake
runs-on: faiss-aws-m7i.large
steps:
- name: Checkout
continue-on-error: true # non-blocking mode for now
uses: actions/checkout@v4
- uses: ./.github/actions/build_cmake
with:
opt_level: avx512
continue-on-error: true # non-blocking mode for now
linux-x86_64-GPU-cmake:
name: Linux x86_64 GPU (cmake)
needs: linux-x86_64-cmake
Expand Down Expand Up @@ -103,13 +100,10 @@ jobs:
name: Linux arm64 SVE (cmake)
needs: linux-x86_64-cmake
runs-on: faiss-aws-r8g.large
continue-on-error: true # non-blocking mode for now
steps:
- name: Checkout
continue-on-error: true # non-blocking mode for now
uses: actions/checkout@v4
- uses: ./.github/actions/build_cmake
continue-on-error: true # non-blocking mode for now
with:
opt_level: sve
linux-x86_64-conda:
Expand Down

0 comments on commit 0b2328f

Please sign in to comment.