Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update astro #1630

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Update astro #1630

merged 3 commits into from
Jan 9, 2025

Conversation

tillprochaska
Copy link
Contributor

No description provided.

@pudo
Copy link
Contributor

pudo commented Jan 8, 2025

Thank you so so so much for handling this, it's been annoying me a bit but not enough to figure out what needed to be done :) Great to have this in sync again!

@tillprochaska
Copy link
Contributor Author

Yes, sorry it took so long. I’m always a bit torn with mostly static stuff like this. On one hand, there’s no rush to always be on the latest version, on the other hand, I’m annoyed by constant Dependabot notifications for "outdated" development dependencies.

I’ve removed a bunch of customizations from the Astro theem to make it easier to update in the future, and will remove a little more when I have more time.

@tillprochaska tillprochaska marked this pull request as ready for review January 8, 2025 10:58
@pudo pudo merged commit e03bb84 into main Jan 9, 2025
8 checks passed
@pudo pudo deleted the update-astro branch January 9, 2025 10:26
tillprochaska added a commit that referenced this pull request Jan 15, 2025
I broke the properties listings the model explorer in #1630. The current Astro version renders `data-key={false}` as `data-key="false"` whereas the previous version would simply omit the entire attribute in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants