Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve crashing issue on IPFS subscription exception #687

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Jan 21, 2025

Fix: Solved program crashing and restart if IPFS subscription raise an issue. Now it handles and log the issue without crashing.

Related Clickup or Jira tickets : ALEPH-359

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Handle the exception with a try, catch and ensure to close the session and open it again on subscription.

How to test

Execute that version on a CCN and check if the container doesn't restart on an exception on IPFS.

…n issue. Now it handles and log the issue without crashing.
@nesitor nesitor self-assigned this Jan 21, 2025
@Psycojoker Psycojoker merged commit 076c677 into main Jan 21, 2025
4 checks passed
@Psycojoker Psycojoker deleted the andres-fix-solve_ipfs_failing_issue branch January 21, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants