Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent delete volumes used by VMs #685

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Jan 15, 2025

Fix: Prevent a store message forget to be executed if the file is already used on a VM.

Related Clickup or Jira tickets : ALEPH-XXX

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

Fix: Prevent a store message forget to be executed if the file is already used on a VM.

How to test

Try to forget a volume that is used by a program or an instance. The forget should be blocked and the API should answer an error.

@nesitor nesitor requested review from Psycojoker, aliel and 1yam January 15, 2025 16:31
@nesitor nesitor self-assigned this Jan 15, 2025
@aliel aliel changed the title Prevernt delete volumes used by VMs Prevent delete volumes used by VMs Jan 16, 2025
@nesitor nesitor merged commit f3be9c8 into main Jan 16, 2025
4 checks passed
@nesitor nesitor deleted the andres-fix-prevent_file_forgot_if_used branch January 16, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants