Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: vm_cost_views missing join with status #684

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Jan 15, 2025

Vm_cost_view needed a join with message_status to avoid having a forgotten vms taking into account on locked_ammount

Related Clickup or Jira tickets : ALEPH-None

Self proofreading checklist

  • Is my code clear enough and well documented
  • Are my files well typed
  • New translations have been added or updated if new strings have been introduced in the frontend
  • Database migrations file are included
  • Are there enough tests
  • Documentation has been included (for new feature)

Changes

This pull request includes a significant update to the vm_costs_view in the database schema to include the message_status field. This change ensures that only VMs with a processed status are considered in the view.

Database Schema Update:

@1yam 1yam requested a review from nesitor January 15, 2025 12:00
@1yam 1yam self-assigned this Jan 16, 2025
@nesitor nesitor merged commit ac9e82d into main Jan 16, 2025
4 checks passed
@nesitor nesitor deleted the 1yam-fix-vm_cost_view branch January 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants