Implement price API #542
Merged
Implement price API #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesitor
force-pushed
the
andres-feature-add_vm_pricing_api
branch
2 times, most recently
from
5ac4393 to
e6004cf
Compare
hoh
reviewed
Jan 16, 2024
src/aleph/web/controllers/prices.py
Outdated
| required_tokens = compute_cost(session=session, content=content) | ||
|
|
||
| return web.Response( | ||
| text=MessagePrice(required_tokens=required_tokens).to_json(), |
There was a problem hiding this comment.
Why use a dataclass here ?
Suggested change
| text=MessagePrice(required_tokens=required_tokens).to_json(), | |
| json={"required_tokens": required_tokens}, |
There was a problem hiding this comment.
This suggestion doesn't work, because web.Response method don't have any json field.
There was a problem hiding this comment.
|
This branch should be based on |
nesitor
force-pushed
the
andres-feature-add_vm_pricing_api
branch
from
f40a897 to
0e91f05
Compare
hoh
force-pushed
the
andres-feature-add_vm_pricing_api
branch
from
3553810 to
179f731
Compare
|
I added the payment type in the JSON response. |
…ance or program VM. Solution: Create a price API to request it just passing the message item hash.
hoh
force-pushed
the
andres-feature-add_vm_pricing_api
branch
from
179f731 to
273df6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We are unable to get the required tokens or flow for an instance or program VM.
Solution: Create a price API to request it just passing the message item hash.