Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Add Unit Test #170

Closed
wants to merge 2 commits into from
Closed

Internal: Add Unit Test #170

wants to merge 2 commits into from

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Oct 3, 2023

Problem:

Solutions:

  • Add Unit test for aleph file upload
  • Add Unit test for aleph account path

Current Coverage : 45 %

@@ -36,6 +37,13 @@ def test_account_export_private_key(account_file: Path):
assert len(result.stdout.strip()) == 66


def test_account_path():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this testing ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test check that path is set well

@@ -73,3 +81,19 @@ def test_message_find():
b"bd79839bf96e595a06da5ac0b6ba51dea6f7e2591bb913deccded04d831d29f4"
in result.stdout
)


def test_file_upload():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a docstring that explains what this is testing ?

@MHHukiewitz
Copy link
Member

Is superseded by #173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants