Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Story Sharing help #561

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Add Story Sharing help #561

merged 1 commit into from
Aug 3, 2023

Conversation

llewelld
Copy link
Collaborator

@llewelld llewelld commented Aug 2, 2023

Adds a flow chart to illustrate the story sharing process, along with some explanatory text, to the help pages.

Contributes to #535.

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Coverage report

The coverage rate went from 98.89% to 98.89% ⬇️

None of the new lines are part of the tested code. Therefore, there is no coverage data about them.

@llewelld
Copy link
Collaborator Author

llewelld commented Aug 2, 2023 •
edited
Loading

I've added the drawio source to the static/images folder, but I'm certain this is the wrong place (we don't need it served on the final site). Any suggestions for where it should go? Maybe we don't need it stored in the repo at all?

@llewelld llewelld marked this pull request as ready for review August 2, 2023 16:11
@llewelld
Copy link
Collaborator Author

llewelld commented Aug 2, 2023

A preview:

image

@llewelld llewelld mentioned this pull request Aug 2, 2023
Closed
3 tasks
gedankenstuecke
gedankenstuecke approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@gedankenstuecke gedankenstuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great addition!

Regarding the question of where to put the source file: It's an excellent question. Generally I'd say somewhere in the 00-project-documentation folder could be a good fit. It's a bit hidden but 00-project-documentation/platform-design/platform-design/platform-content seems like it could fit?

@llewelld
Add Story Sharing help
7441651 
Adds a flow chart to illustrate the story sharing process, along with
some explanatory text, to the help pages.

Contributes to alan-turing-institute#535.
@llewelld
Copy link
Collaborator Author

llewelld commented Aug 3, 2023

Regarding the question of where to put the source file: It's an excellent question. Generally I'd say somewhere in the 00-project-documentation folder could be a good fit. It's a bit hidden but 00-project-documentation/platform-design/platform-design/platform-content seems like it could fit?

That's perfect; thank you! I've moved the source diagram file into that folder.

gedankenstuecke
gedankenstuecke approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@gedankenstuecke gedankenstuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, then I'd say this is good to go!

@llewelld llewelld merged commit 7434119 into alan-turing-institute:main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gedankenstuecke gedankenstuecke gedankenstuecke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llewelld @gedankenstuecke