Skip to content

Commit

Permalink
Minor: Document how to test for trailing whitespace
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb committed Nov 1, 2024
1 parent fa96eb3 commit d7d1e59
Show file tree
Hide file tree
Showing 2 changed files with 50 additions and 0 deletions.
33 changes: 33 additions & 0 deletions datafusion/sqllogictest/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,39 @@ SELECT * from foo;

Assuming it looks good, check it in!

## Cookbook: Testing for whitespace

The `sqllogictest` runner will automatically strip trailing whitespace, meaning
it additional effort to verify that trailing whitespace is correctly produced

For example, the following test can't distinguish between `Andrew` and `Andrew `
(with trailing space):

```text
query T
select substr('Andrew Lamb', 1, 7)
----
Andrew
```

To test trailing whitespace, project additional non-whitespace column on the
right. For example, by selecting `'XX'` after the column of interest, the test
can distinguish between `Andrew` and `Andrew `:

```text
# Note two spaces between `Andrew` and `XX`
query TT
select substr('Andrew Lamb', 1, 7), 'XX';
----
Andrew XX
# Note only one space between `Andrew` and `XX`
query TT
select substr('Andrew Lamb', 1, 6), 'XX';
----
Andrew XX
```

# Reference

## Running tests: Validation Mode
Expand Down
17 changes: 17 additions & 0 deletions datafusion/sqllogictest/test_files/functions.slt
Original file line number Diff line number Diff line change
Expand Up @@ -735,3 +735,20 @@ query B
select contains('', '');
----
true


## Demonstrate how to test for trailing whitespace
query T
select substr('Andrew Lamb', 1, 7)
----
Andrew

query TT
select substr('Andrew Lamb', 1, 7), 'XX'
----
Andrew XX

query TT
select substr('Andrew Lamb', 1, 6), 'XX'
----
Andrew XX

0 comments on commit d7d1e59

Please sign in to comment.