Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nvim themes from ghostty #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add nvim themes from ghostty #139

wants to merge 2 commits into from

Conversation

xdannyrobertsx
Copy link

@xdannyrobertsx xdannyrobertsx commented Jan 10, 2025 •
edited
Loading

Ghostty allows for configuring the color scheme through its CLI via the ghostty +list-themes. These are actually sourced from iTerm Themes
nvim_dark

nvim_light

chrisduerr
chrisduerr requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they're nvim themes, I'd expect them to come from the neovim repo. Why is this using ghostty's iterm nvim theme rather than going straight to the source? Seems like a somewhat ridiculous level of indirection.

themes/nvim_dark.toml
@@ -0,0 +1,33 @@
# Color theme ported from Ghostty NvimDark theme
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does Ghostty contribute here? You said yourself these are just from iterm's website?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iTerm contains these themes, but from what i've seen, Ghostty's been the one to popularize them. I didn't initially find that these themes came from iTerm, when I looked at them through Ghostty's theme selector, so if I were a new user and were searching for the theme, I might use the term Ghostty.

I'm more than happy to change the name of the PR and any references to Ghostty, just let me know please.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is to reference the original source, since it's where the theme is developed/etc, I'd really expect the neovim itself to be the source though, to some extent...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the theme name simply references Nvim, but doesn't actually come from it. The source of the colors seem to come from iTerm itself:

https://raw.githubusercontent.com/mbadolato/iTerm2-Color-Schemes/master/schemes/NvimLight.itermcolors

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way they don't come from ghostty, so that's certainly not the correct source.

themes/nvim_light.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov left review comments

@chrisduerr chrisduerr chrisduerr requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xdannyrobertsx @chrisduerr @kchibisov