Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent from accessing AnimationController when it was disposed #335

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Prevent from accessing AnimationController when it was disposed #335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/src/panel.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,9 @@ class _SlidingUpPanelState extends State<SlidingUpPanel>

// handles the sliding gesture
void _onGestureSlide(double dy) {
// Prevent from accessing AnimationController methods after calling dispose on it
if (!mounted) return;

// only slide the panel if scrolling is not enabled
if (!_scrollingEnabled) {
if (widget.slideDirection == SlideDirection.UP)
Expand All @@ -491,6 +494,9 @@ class _SlidingUpPanelState extends State<SlidingUpPanel>

// handles when user stops sliding
void _onGestureEnd(Velocity v) {
// Prevent from accessing AnimationController methods after calling dispose on it
if (!mounted) return;

double minFlingVelocity = 365.0;
double kSnap = 8;

Expand Down