Give isPanelOpen and isPanelClosed tolerance equal to _kFlingTolerance #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, sometimes after a fling open isPanelOpen would return false, or after a fling closed isPanelClosed would return false.
willbryant
force-pushed
the
fix_panel_open_closed_after_fling
branch
from
23ec458 to
2e01178
Compare
|
Rebased to master. |
|
yeah, maybe its bug. when use isPanelOpen still return false. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, sometimes after a fling open isPanelOpen would return false, or after a fling closed isPanelClosed would return false.