Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unscrollable lists when slide direction is down. handle reverse lists. #217

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

fix unscrollable lists when slide direction is down. handle reverse lists. #217

wants to merge 15 commits into from

Conversation

zakton5
Copy link

@zakton5 zakton5 commented Jan 18, 2021

Fixes #215

This PR fixes the following scenarios

  • Scrollable content in the panel when slideDirection == SlideDirection.DOWN did not scroll at all
  • Strange list behavior when reverse == true for both SlideDirection.DOWN and SlideDirection.UP

To test

  1. Run the example project

  2. Use all 4 of the following configurations and verify that each one opens, scrolls, and closes as expected.

    • List reverse: false, SlidingUpPanel slideDirection: SlideDirection:UP
    • List reverse: true, SlidingUpPanel slideDirection: SlideDirection:UP
    • List reverse: false, SlidingUpPanel slideDirection: SlideDirection:DOWN
    • List reverse: true, SlidingUpPanel slideDirection: SlideDirection:DOWN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When slide direction is down, list view inside panel does not scroll
3 participants
@zakton5 @uintdev @akshathjain