Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Provide rule to set a debian package #13

Closed
wants to merge 2 commits into from

Conversation

camlafit
Copy link

@camlafit camlafit commented May 23, 2023

  • Initialize context to generate Debian package
  • Retrieve package with dpkg-buildpackage -us -uc -b

cf #12

* Initialize context to generate debian package
* ```dpkg-buildpackage -us -uc -b```
@aklomp
Copy link
Owner

aklomp commented May 25, 2023

Thanks for the pull request, I appreciate it. However, I don't think it's appropriate to include this code into this project itself. It's intended to be small, focused and portable, and adding distro-specific packaging stuff does not fit that mission.

If it's done this way, there is also a messy circular dependency involving the changelog: if I create a release, then I have to remember to update the changelog beforehand, but I can't update the release time because it's not yet known.

Again I appreciate the work, but I think it should be in a separate repository (shrinkpdf-debian or something) that pulls shrinkpdf as a versioned submodule.

@aklomp aklomp self-assigned this May 25, 2023
@aklomp aklomp added enhancement New feature or request wontfix This will not be worked on labels May 25, 2023
@camlafit
Copy link
Author

Hello

Thanks for your reply.
I'll do differently. We can close this issue :)
I can do an external project. Will without submodule as it's an ugly feature. Maybe I'll do a curl query to release api to follow new version.

Thanks a lot

@camlafit camlafit closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants