Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git-issue-jira-automation workflow #108

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

OriBenHur-akeyless
Copy link

No description provided.

Comment on lines 77 to 89
- name: Slack Success Notification
if: env.jira_issue_exist == 'false' && github.event.action == 'opened'
uses: rtCamp/action-slack-notify@v2
env:
SLACK_CHANNEL: 'operations'
SLACK_COLOR: ${{ job.status }}
SLACK_ICON: https://github.com/rtCamp.png?size=48
SLACK_TITLE: 'New Git Issue Created'
SLACK_MESSAGE: '${{ env.slack-message }}'
SLACK_USERNAME: githubBot
SLACK_WEBHOOK: ${{ secrets.SLACK_OPERATIONS_WEBHOOK }}
MSG_MINIMAL: true
SLACK_FOOTER: GitHub Issue To Jira Automation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think sending slack message to operations is not a good idea, if you still want to send slack messages, please send them to a dedicated channel. Also i would add a failure message for us to understand if we have any issue with this automation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please send slack to dedicated channel

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this change

Comment on lines +38 to +42
- name: Find Existing Jira issue
if: env.jira_issue_exist == 'true'
uses: atlassian/gajira-find-issue-key@v3
with:
string: ${{ env.akeyless_jira_issue }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if not used

Comment on lines +59 to +64
- name: Add Comment On Jira issue
if: env.jira_issue_exist == 'true' && (github.event_name == 'issue_comment' || (github.event_name == 'issues' && github.event.action == 'closed'))
uses: atlassian/gajira-comment@v3
with:
issue: ${{ env.akeyless_jira_issue }}
comment: ${{ env.jira_description }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove if not used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants