Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inventory api proto updates with service.proto add for grpc server #98

Closed

Conversation

chainzero
Copy link

No description provided.

@chainzero chainzero requested a review from a team as a code owner December 14, 2023 14:16
(gogoproto.moretags) = "yaml:\"size\""
string totalsize = 3 [
(gogoproto.customname) = "TotalSize",
(gogoproto.jsontag) = "totalsize",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"total_size"

@@ -6,6 +6,7 @@ import "gogoproto/gogo.proto";
import "akash/inventory/v1/resourcepair.proto";

option go_package = "github.com/akash-network/akash-api/go/inventory/v1";
option (gogoproto.gogoproto_import) = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be sufficient to set this option in only resourcevpair proto

@chainzero chainzero closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants