Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(market): add resource offer into bid object #89

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

troian
Copy link
Member

@troian troian commented Nov 1, 2023

No description provided.

@troian troian requested a review from a team as a code owner November 1, 2023 00:37
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 5947 lines in your changes are missing coverage. Please review.

Comparison is base (13a2a5f) 3.52% compared to head (2484872) 3.42%.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #89      +/-   ##
========================================
- Coverage   3.52%   3.42%   -0.11%     
========================================
  Files        276     293      +17     
  Lines      88227   96697    +8470     
========================================
+ Hits        3110    3310     +200     
- Misses     84959   93222    +8263     
- Partials     158     165       +7     
Files Coverage Δ
go/node/market/v1beta4/query.pb.go 0.59% <ø> (ø)
go/node/market/v1beta4/key.go 0.00% <0.00%> (ø)
go/node/market/v1beta4/codec.go 50.00% <50.00%> (ø)
go/node/market/v1beta4/bid.go 0.00% <0.00%> (ø)
go/node/deployment/v1beta3/resourceunit.pb.go 2.46% <0.00%> (-0.23%) ⬇️
go/node/market/v1beta4/escrow.go 0.00% <0.00%> (ø)
go/node/market/v1beta4/params.go 0.00% <0.00%> (ø)
go/node/market/v1beta4/id.go 0.00% <0.00%> (ø)
go/node/market/v1beta4/event.go 62.44% <62.44%> (ø)
go/node/market/v1beta4/msgs.go 0.00% <0.00%> (ø)
... and 8 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@troian troian force-pushed the bid-attributes branch 2 times, most recently from 7c01c59 to d354adf Compare November 1, 2023 15:54
@troian troian merged commit ea71fbd into main Nov 1, 2023
4 of 6 checks passed
@troian troian deleted the bid-attributes branch November 1, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant