Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check attr is nil prior going copy #74

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: check attr is nil prior going copy #74

merged 1 commit into from
Sep 1, 2023

Conversation

troian
Copy link
Member

@troian troian commented Sep 1, 2023

No description provided.

@troian troian requested a review from a team as a code owner September 1, 2023 17:39
@troian troian merged commit fed1855 into main Sep 1, 2023
3 checks passed
@troian troian deleted the check-attr branch September 1, 2023 17:43
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 68.29% and project coverage change: +0.02% 🎉

Comparison is base (f96c282) 3.49% compared to head (5e7dd5e) 3.52%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #74      +/-   ##
========================================
+ Coverage   3.49%   3.52%   +0.02%     
========================================
  Files        276     276              
  Lines      88188   88227      +39     
========================================
+ Hits        3084    3110      +26     
- Misses     84946   84959      +13     
  Partials     158     158              
Files Changed Coverage Δ
go/node/deployment/v1beta3/resourceunit.go 72.07% <0.00%> (-4.12%) ⬇️
go/node/deployment/v1beta3/resourceunits.go 27.08% <0.00%> (-4.63%) ⬇️
go/manifest/v2beta2/group.go 44.73% <100.00%> (ø)
go/manifest/v2beta2/groups.go 76.27% <100.00%> (+0.83%) ⬆️
go/manifest/v2beta2/service.go 87.14% <100.00%> (ø)
go/node/deployment/v1beta3/groupspec.go 97.39% <100.00%> (+0.42%) ⬆️
go/node/types/v1beta3/attribute.go 74.11% <100.00%> (+1.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant