Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proto): use slices instead of maps #69

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

troian
Copy link
Member

@troian troian commented Aug 3, 2023

hashmap might be a cause of inconsistent AppHash

@troian troian requested a review from a team as a code owner August 3, 2023 18:03
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (be66b66) 3.44% compared to head (db3accb) 3.44%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #69   +/-   ##
=====================================
  Coverage   3.44%   3.44%           
=====================================
  Files        276     276           
  Lines      88247   88187   -60     
=====================================
- Hits        3038    3037    -1     
+ Misses     85046   84987   -59     
  Partials     163     163           
Files Changed Coverage Δ
go/manifest/v2beta2/manifest.go 58.62% <0.00%> (-41.38%) ⬇️
go/node/deployment/v1beta3/params.go 0.00% <0.00%> (ø)
go/node/deployment/v1beta3/params.pb.go 1.73% <0.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hashmap might be a cause of inconsistent AppHash

Signed-off-by: Artur Troian <[email protected]>
@troian troian merged commit 9f6946b into main Aug 3, 2023
4 checks passed
@troian troian deleted the troian/maps2slices branch August 3, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant