fix(go): do not delete deposit authz when remaining limit is 0 (#162)

Signed-off-by: Artur Troian <[email protected]>

go/node/deployment/v1beta3/deposit_deployment_authorization.go

@@ -32,9 +32,6 @@ func (m DepositDeploymentAuthorization) Accept(_ sdk.Context, msg sdk.Msg) (auth
 		return authz.AcceptResponse{}, sdkerrors.ErrInsufficientFunds.Wrapf("requested amount is more than spend limit")
 	}
 	limitLeft := m.SpendLimit.Sub(mDepositDeployment.Amount)
-	if limitLeft.IsZero() {
-		return authz.AcceptResponse{Accept: true, Delete: true}, nil
-	}
 
 	return authz.AcceptResponse{Accept: true, Delete: false, Updated: &DepositDeploymentAuthorization{SpendLimit: limitLeft}}, nil
 }

go/node/deployment/v1beta3/types_test.go

@@ -452,10 +452,10 @@ func TestDepositDeploymentAuthorization_Accept(t *testing.T) {
 	dda, ok = response.Updated.(*types.DepositDeploymentAuthorization)
 	require.True(t, ok)
 
-	// Deposit the limit (now 1), expect that it is deleted
+	// Deposit the limit (now 1), expect that it is not to be deleted
 	msg = types.NewMsgDepositDeployment(testutil.DeploymentID(t), sdk.NewInt64Coin(tutil.CoinDenom, 1), testutil.AccAddress(t).String())
 	response, err = dda.Accept(sdk.Context{}, msg)
 	require.NoError(t, err)
 	require.True(t, response.Accept)
-	require.True(t, response.Delete)
+	require.False(t, response.Delete)
 }