Improve Variable#increment() bytecode generation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies Variable#increment() to generate IINC instructions where possible instead of multi-bytecode sequences of load, add, store that it previously used. Also fixes handling of incrementing primitive long values to avoid failing as a result of a type mismatch between the variable's long type and the type of constantInt(1).
dain
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies
Variable#increment()to generate IINC instructions where possible instead of multi-bytecode sequences of load, add, and store that it previously used. Also fixes handling of incrementing primitive long values to avoid failing as a result of a type mismatch between the variable's long type and the type ofconstantInt(1).