fix: don't break iteraction urls with a custom prefix #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for the PR. Is this something that is not working at the moment? We are currently working on a new version of our serializer (the old one will stay around for a while to not break backwards compatibility), and with that change, we want to improve the callback parameter anyway. |
Yep, currently, Vault can't open Base aepp by universal link.
Do you mean v3? We just noticed v2 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Base aepp, we are using a custom one: https://github.com/aeternity/aepp-base/blob/4a6b929c4e01a8d9ce1b3a0a1e4e6f4e6c16258a/src/lib/airGap.js#L6
The URL breaks this way:
airgap-wallet://?d=com/airgap?d=UgoPLk4k...